Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard on windows #14

Open
edouard-lopez opened this issue Apr 8, 2019 · 3 comments
Open

Clipboard on windows #14

edouard-lopez opened this issue Apr 8, 2019 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@edouard-lopez
Copy link
Owner

edouard-lopez commented Apr 8, 2019

From PowerShell Slack

chrisdent [13 h 28]
you'll hit a bug in win PS because you're using $IsWindows in your GetSystemCopyCommand function. You could use Set-Clipboard on Windows.
https://github.com/edouard-lopez/lesspass-powershell/blob/master/Clipboard.tests.ps1#L5-L9 I'm pretty sure your test will never fail

$IsWindows exists in PowerShell Core (6+), but not in 5.1 and below. If you want backwards compatibility you'll need to reconsider OS discovery a little.
I plan to use ClipboardText module

@edouard-lopez edouard-lopez added bug Something isn't working help wanted Extra attention is needed labels Apr 8, 2019
@jzabroski
Copy link

You should avoid using the clipboard for passwords. If any applications have access to the system clipboard, this is "as if" you have installed a key logger. This is the most frequently reported vulnerability for password managers like LastPass, Dashlane and other password managers on Android Devices that let users plug in a different password manager than the default. I have contacted the various vendors and NONE of them are doing ANYTHING to fix this problem.

@jzabroski
Copy link

If you do decide to support the clipboard, it's probably best to create a background job in PowerShell to clear the clipboard entry after N minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants