Skip to content
This repository has been archived by the owner on Jan 8, 2023. It is now read-only.

Tabs are no longer compact as of v2.1.0 #6

Closed
reicordine opened this issue Jul 14, 2021 · 12 comments
Closed

Tabs are no longer compact as of v2.1.0 #6

reicordine opened this issue Jul 14, 2021 · 12 comments
Labels
bug Something isn't working cannot reproduce good first issue Good for newcomers help wanted Extra attention is needed

Comments

@reicordine
Copy link

reicordine commented Jul 14, 2021

While v2.1.0 has fixed the issue I had with the context menu having broken formatting (thanks!), the tabs are no longer compact even with compact density enabled; they are instead the size of the normal density tabs of Proton.

v1.1.2 does not have this issue. I don't think that v2.0.0 had this issue either.

@edo0 edo0 added bug Something isn't working good first issue Good for newcomers labels Jul 14, 2021
@edo0
Copy link
Owner

edo0 commented Jul 14, 2021

Thank you very much for the bug report! I do not currently have a Windows computer to test this, could you please upload a screenshot/gif of what what the bug manifests like?

@reicordine
Copy link
Author

Sure thing. Here's an image comparing the tabs of v1.1.2 to v2.1.0 (some poor cropping on my part, sorry):

compact-technetium

As you can see, the tabs are much taller now.

@edo0
Copy link
Owner

edo0 commented Jul 14, 2021

Thank you very much, tonight I will have a look into it and will get back to you

@edo0
Copy link
Owner

edo0 commented Jul 14, 2021

Could you please try using this userChrome and tell me if it fixes your issue?
userChrome.css.zip

@reicordine
Copy link
Author

Unfortunately I still have the issue when replacing the old userChrome.css with your new file.

@edo0
Copy link
Owner

edo0 commented Jul 14, 2021

Could you please confirm whether also 2.0.0 yielded such an abnormal behaviour, or was introduced specifically with 2.1.0?

@reicordine
Copy link
Author

I can confirm that the tabs are still compact as expected in v2.0.0.

@edo0
Copy link
Owner

edo0 commented Jul 14, 2021

Thank you for your feedback
New attempt, else it may have something to do with upstream (Lepton), and I will report this issue to its dev as well
userChrome.css.zip

PS: sorry to make this more labour intensive for you, unfortunately this behaviour is completely non-reproducible on Linux

@reicordine
Copy link
Author

Sorry for the delay in testing out the new userChrome. Unfortunately I'm still having the issue when trying the new userChrome.

I don't mind testing this for you, it's no problem.

@edo0 edo0 pinned this issue Jul 15, 2021
@edo0 edo0 added cannot reproduce help wanted Extra attention is needed labels Jul 15, 2021
@edo0
Copy link
Owner

edo0 commented Jul 15, 2021

I have tried version 2.1.1, just released, on a Windows 7 machine without issues (FF 90).
Could you please try this latest version on a friend or family member's Firefox / a clean nightly install, to make sure Technetium is to blame - and that no other configuration may be interfering?

@reicordine
Copy link
Author

Hey, I've just tried the 2.1.1 release on this same Windows 10 device (I have no other devices) and I can confirm that you have solved the issue and tabs are now compact as they should be. Thanks and great job!

@edo0
Copy link
Owner

edo0 commented Jul 15, 2021

Great to know!! Thank you for assisting me in testing this!

@edo0 edo0 closed this as completed Jul 15, 2021
@edo0 edo0 unpinned this issue Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working cannot reproduce good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants