Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to typescript #72 #73

Merged
merged 18 commits into from
Jul 30, 2024
Merged

Conversation

yuan-93
Copy link
Contributor

@yuan-93 yuan-93 commented Jun 20, 2024

Resolve #72 Migrate to Typescript

Changes

  1. Add Typescript
  2. Add dev dependencies @editorjs/editorjs to use its type
  3. Add .d.ts for @codexteam/icons
  4. Convert js files to ts files and update relevant interfaces and types
  5. Add type-guard to safely infer js Node to HtmlElement
  6. Add tsconfig.json
  7. Add vite-plugin-dts to generate types during build
  8. Add dev dependencies @typescript-eslint/eslint-plugin, @typescript-eslint/parser to support eslint typescript
  9. Update "yarn lint" to target .ts files
  10. Copy editorconfig from @editorjs/editorjs to have same code formatting
  11. Add "yarn build" on pull request at github workflow to build dist folder
  12. Increment patch version from v1.4.2 to v1.4.3

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

.github/workflows/eslint.yml Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/utils/caret.ts Show resolved Hide resolved
src/utils/dom.ts Outdated Show resolved Hide resolved
@yuan-93
Copy link
Contributor Author

yuan-93 commented Jul 7, 2024

Thanks for reviewing @neSpecc
Here are the changes made according to your review

Changes

  1. remove build step in eslint github workflow
  2. use and update list data style
  3. make default style optional
  4. make dom helper allow to add any attributes
  5. update to use readied type from editorjs
  6. update doc

src/index.ts Outdated Show resolved Hide resolved
src/types/icons.d.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@neSpecc
Copy link
Contributor

neSpecc commented Jul 26, 2024

Hey, @yuan-93, would you help us finishing this pr? We're planning a big update of this tool, so this step is important.

@yuan-93
Copy link
Contributor Author

yuan-93 commented Jul 26, 2024

yea @neSpecc , I think i will helpout in this weekend

@neSpecc
Copy link
Contributor

neSpecc commented Jul 30, 2024

Thanks, @yuan-93, very professional work. If you are interested in continuing, let me know.

@neSpecc neSpecc merged commit 591bd2c into editor-js:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Type Script
2 participants