feat (road to typescript): migrate from javascript to typescript #252

dependentmadani · 2024-06-18T17:40:35Z

hello @neSpecc, please check this pull request

src/ui.ts

src/types/types.ts

src/ui.ts

src/uploader.ts

package.json

src/index.ts

package.json

src/index.ts

src/types/types.ts

src/index.ts

src/ui.ts

src/uploader.ts

…r module, as well as Image class

package.json

src/index.ts

src/types/types.ts

src/index.ts

src/types/types.ts

src/index.ts

src/uploader.ts

src/index.ts

src/ui.ts

src/index.ts

src/uploader.ts

src/index.ts

src/types/codexteam-icons.d.ts

src/types/types.ts

src/uploader.ts

neSpecc

You also need to add yarn build step on ci (GitHub actions)

.eslintrc

.github/workflows/npm-publish.yml

package.json

src/uploader.ts

…vided

src/types/types.ts

…oolData and UploadResponseFormat

src/types/types.ts

feat (road to typescript): migrate from javascript to typescript

65969bb

neSpecc reviewed Jun 18, 2024

View reviewed changes

src/ui.ts Outdated Show resolved Hide resolved

src/types/types.ts Outdated Show resolved Hide resolved

src/ui.ts Outdated Show resolved Hide resolved

src/uploader.ts Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

update (fix the issues): changes after the review

76ff281

neSpecc requested changes Jun 19, 2024

View reviewed changes

refactor (multiple modification): Refactore image tool UI and uploade…

b85e432

…r module, as well as Image class

neSpecc reviewed Jun 19, 2024

View reviewed changes

refactor: few modification from last review

e071d6a

neSpecc requested changes Jun 19, 2024

View reviewed changes

neSpecc reviewed Jun 19, 2024

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

neSpecc reviewed Jun 19, 2024

View reviewed changes

src/index.ts Outdated Show resolved Hide resolved

refactor: fix multiple issues

7edd811

neSpecc requested changes Jun 23, 2024

View reviewed changes

fix (few modification): modification reviews by neSpecc

c51ca26

neSpecc reviewed Jun 26, 2024

View reviewed changes

update (in different files): fix the issues thanks to the reviews

e21fece

neSpecc reviewed Jun 29, 2024

View reviewed changes

neSpecc requested changes Jun 29, 2024

View reviewed changes

dependentmadani added 2 commits July 4, 2024 15:08

update(last review): modifications based on last review

e79366d

fix(icons): remove manual declaration of icons types

c8c21c3

neSpecc reviewed Jul 4, 2024

View reviewed changes

.eslintrc Outdated Show resolved Hide resolved

.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

src/uploader.ts Outdated Show resolved Hide resolved

src/uploader.ts Outdated Show resolved Hide resolved

update(reviewed): fix minor possible issues thanks to the reviews pro…

a5f7ad1

…vided

neSpecc reviewed Jul 6, 2024

View reviewed changes

src/types/types.ts Show resolved Hide resolved

src/types/types.ts Show resolved Hide resolved

dependentmadani added 2 commits July 6, 2024 15:31

update(interfaces): possbile additional data in file object an ImageT…

d265261

…oolData and UploadResponseFormat

update: use generic types instead of Record

1a12e9a

neSpecc reviewed Jul 8, 2024

View reviewed changes

src/types/types.ts Outdated Show resolved Hide resolved

update(naming): change the naming of a generic type

dc750a5

neSpecc approved these changes Jul 8, 2024

View reviewed changes

neSpecc merged commit 1d9f0e7 into editor-js:master Jul 8, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat (road to typescript): migrate from javascript to typescript #252

feat (road to typescript): migrate from javascript to typescript #252

dependentmadani commented Jun 18, 2024

neSpecc left a comment

feat (road to typescript): migrate from javascript to typescript #252

feat (road to typescript): migrate from javascript to typescript #252

Conversation

dependentmadani commented Jun 18, 2024

neSpecc left a comment

Choose a reason for hiding this comment