Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Redis adapter #8

Closed
edisonywh opened this issue Aug 12, 2019 · 2 comments
Closed

Add a Redis adapter #8

edisonywh opened this issue Aug 12, 2019 · 2 comments
Assignees
Labels
discussion Open to discussion! enhancement New feature or request

Comments

@edisonywh
Copy link
Owner

After #6 is merged, it should be pretty easy to just plug in a Redis adapter, which is largely true.

However, one problem that I encountered while trying to implement it in #7 is that it's not possible to marshal/unmarshal Procs.

Since currently that's the implementation of the in-memory Registry currently (keep a reference to Proc so we can execute later when notifying consumers), we might need to rethink the strategy of how to notify customers, or just deviate slightly for a redis adapter (if so, different how?)

This might require a bit more discussion on how to proceed, so welcome any discussion here!

@edisonywh edisonywh added discussion Open to discussion! enhancement New feature or request labels Aug 12, 2019
@edisonywh
Copy link
Owner Author

Perhaps a bit of a mistake on my part, looks like there's no real need to store the entire Registry into Redis, what really matters is the jobs in Rocketman::Pool.

When the app dies, we should persist the queue to Redis, and when the app starts, we should rehydrate the job queue from Redis

@edisonywh edisonywh self-assigned this Aug 17, 2019
@edisonywh
Copy link
Owner Author

This is resolved in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open to discussion! enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant