-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added error handling for status 404 #160
Conversation
Signed-off-by: Kyle Morton <[email protected]>
@drkfmorton Please fix linter error. [2022-08-24T17:37:28.375Z] internal/pkg/vault/secrets_test.go:49:2: Suggest installing golangci-lint on your path so that linting can be done before checkin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kyle Morton <[email protected]>
77d5229
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 77.88% 77.37% -0.52%
==========================================
Files 17 17
Lines 900 906 +6
==========================================
Hits 701 701
- Misses 142 147 +5
- Partials 57 58 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Kyle Morton [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-secrets/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)