Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added error handling for status 404 #160

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

drkfmorton
Copy link
Contributor

@drkfmorton drkfmorton commented Aug 24, 2022

Signed-off-by: Kyle Morton [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-secrets/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

bnevis-i
bnevis-i previously approved these changes Aug 24, 2022
@bnevis-i bnevis-i requested a review from lenny-goodell August 24, 2022 17:43
@bnevis-i
Copy link
Collaborator

@drkfmorton Please fix linter error.

[2022-08-24T17:37:28.375Z] internal/pkg/vault/secrets_test.go:49:2: testPathNotFound is unused (deadcode)

Suggest installing golangci-lint on your path so that linting can be done before checkin.

@bnevis-i bnevis-i self-requested a review August 24, 2022 17:45
lenny-goodell
lenny-goodell previously approved these changes Aug 24, 2022
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kyle Morton <[email protected]>
@drkfmorton drkfmorton dismissed stale reviews from lenny-goodell and bnevis-i via 77d5229 August 24, 2022 22:20
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #160 (77d5229) into main (f827f68) will decrease coverage by 0.51%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   77.88%   77.37%   -0.52%     
==========================================
  Files          17       17              
  Lines         900      906       +6     
==========================================
  Hits          701      701              
- Misses        142      147       +5     
- Partials       57       58       +1     
Impacted Files Coverage Δ
pkg/errors.go 0.00% <0.00%> (ø)
internal/pkg/vault/secrets.go 73.81% <100.00%> (-0.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bnevis-i bnevis-i merged commit c185b68 into edgexfoundry:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants