Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove unclear HTTP status code #646

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

weichou1229
Copy link
Member

@weichou1229 weichou1229 commented Jul 14, 2021

Close #645

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #645

What is the new behavior?

  • Remove the 0 status code
  • KindIOError uses 403 as the status code

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

- Remove the 0 status code
- KindIOError uses 403 as the status code

Close: edgexfoundry#645
Signed-off-by: weichou <[email protected]>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We should use KindUnknown for any uncertain error, and add new error type if needed

@codecov-commenter
Copy link

Codecov Report

Merging #646 (8b9ffd9) into main (490a961) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
+ Coverage   62.59%   62.64%   +0.04%     
==========================================
  Files          75       75              
  Lines        2751     2749       -2     
==========================================
  Hits         1722     1722              
+ Misses        864      862       -2     
  Partials      165      165              
Impacted Files Coverage Δ
errors/types.go 36.28% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490a961...8b9ffd9. Read the comment docs.

@cloudxxx8 cloudxxx8 merged commit 5e91c92 into edgexfoundry:main Jul 21, 2021
@weichou1229 weichou1229 deleted the issue-645 branch July 21, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unclear HTTP status code
3 participants