-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notifications): Add factory method for Notification DTO #531
Conversation
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
+ Coverage 56.49% 56.63% +0.13%
==========================================
Files 119 119
Lines 3556 3567 +11
==========================================
+ Hits 2009 2020 +11
Misses 1357 1357
Partials 190 190
Continue to review full report at Codecov.
|
Signed-off-by: Felix Ting <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Felix Ting [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #530
What is the new behavior?
Added factory method for Notification DTO.
Close #530
Does this PR introduce a breaking change?
New Imports