-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure exit with non-zero code when error occurs #358
Conversation
fixes #318 Signed-off-by: Leonard Goodell <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 60.37% 60.33% -0.05%
==========================================
Files 22 22
Lines 1378 1379 +1
==========================================
Hits 832 832
- Misses 512 513 +1
Partials 34 34
Continue to review full report at Codecov.
|
Signed-off-by: Leonard Goodell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also add comment why not logging error Signed-off-by: Leonard Goodell <[email protected]>
Signed-off-by: Leonard Goodell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes #318
Signed-off-by: Leonard Goodell [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Use this branch in device SDK and Device Rest
Run Device Rest
Press control C
Verify
echo $?
returns 0Run Device Rest
Run Device Rest in another terminal
Verify if fails due to port bind error
Verify
echo $?
returns 1New Dependency Instructions (If applicable)