fix(config): ignore first change notification in ListenForCustomConfi… #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gChanges The first change notification causes issues with values that have been overriden. It needs to be ignored, similar to regular config ListenForChanges. Fixes edgexfoundry#314 Signed-off-by: Jennifer Williams <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 56.83% 56.62% -0.21%
==========================================
Files 18 18
Lines 1105 1109 +4
==========================================
Hits 628 628
- Misses 453 457 +4
Partials 24 24
Continue to review full report at Codecov.
|
lenny-goodell
approved these changes
Mar 28, 2022
jinlinGuan
pushed a commit
to IOTechSystems/go-mod-bootstrap
that referenced
this pull request
Apr 29, 2022
…gChanges (edgexfoundry#315) The first change notification causes issues with values that have been overriden. It needs to be ignored, similar to regular config ListenForChanges. Fixes edgexfoundry#314 Signed-off-by: Jennifer Williams <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gChanges
The first change notification causes issues with values that have
been overriden. It needs to be ignored, similar to regular config
ListenForChanges.
Fixes #314
Signed-off-by: Jennifer Williams [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Tested with WSL using the
app-functions-sdk-go/app-service-template. Consul already running,make buildthe new-app-service, and apply override of SomeValue with anything other than default 123:APPCUSTOM_SOMEVALUE=334 ./new-app-service -cpNew Dependency Instructions (If applicable)