Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct name when logging EDGEX_CONF_DIR override #266

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/master/.github/Contributing.md.

What is the current behavior?

Logging for EDGEX_CONF_DIR override uses incorrect name envFile

Issue Number: #264

What is the new behavior?

Logging for EDGEX_CONF_DIR override uses correct name envConfDir

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell lenny-goodell linked an issue Aug 5, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #266 (96e528d) into main (3e2f67e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   58.90%   58.90%           
=======================================
  Files          12       12           
  Lines         786      786           
=======================================
  Hits          463      463           
  Misses        309      309           
  Partials       14       14           
Impacted Files Coverage Δ
bootstrap/environment/variables.go 90.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2f67e...96e528d. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 2a375e7 into edgexfoundry:main Aug 5, 2021
@lenny-goodell lenny-goodell deleted the log-fix branch August 5, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging of EDGEX_CONF_DIR override is incorrect
3 participants