feat: Use SecretProvider to get Config/Registry access tokens #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
force-pushed
the
access-token-vault
branch
from
3cc5534 to
a5f44bb
Compare
added 2 commits
April 6, 2021 16:04
SecretProvider now created during config processing and used to get access token(s) when using Config and registry clients closes #199 Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
access-token-vault
branch
from
a5f44bb to
82dd4e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 48.24% 52.47% +4.23%
==========================================
Files 15 11 -4
Lines 711 646 -65
==========================================
- Hits 343 339 -4
+ Misses 356 293 -63
- Partials 12 14 +2
Continue to review full report at Codecov.
|
bnevis-i
reviewed
Apr 6, 2021
bnevis-i
approved these changes
Apr 6, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/master/.github/Contributing.md.
What is the current behavior?
SecretProvider currently create via bootstrap handler long after Config and Registry clients are created.
Issue Number: #199
What is the new behavior?
SecretProvider now created during config processing and used to get access tokens when creating the Config and registry clients
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information