feat(core-data):To improve core-data fuzzing test coverage with swagger… #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing Instructionsrun it with restler fuzzing test tool what is the expected output, can you add an example to check against it? |
bnevis-i
previously approved these changes
Sep 21, 2023
|
@vli11 Fuzzing is not a scope. See https://github.com/edgexfoundry/edgex-go/blob/main/.github/semantic.yml#L15 |
…er file update Closes: edgexfoundry#4689 Signed-off-by: Valina Li <[email protected]>
vli11
force-pushed
the
core-data_swagger_file
branch
from
7db33fe to
890e7d3
Compare
vli11
changed the title
Signed-off-by: Valina Li <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
@jim-wang-intel I've updated test instruction and added fuzzing core-data test target. |
I just amended the PR message. @bnevis-i |
bnevis-i
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… file update
Closes: #4689
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
run with restler fuzzing test tool:
make docker-fuzz
make fuzz-test-data
the coverage was 20/23 before, but with this PR change, and a manual fix on restler grammar, I'm able to get it to 23/23 coverage.
New Dependency Instructions (If applicable)