Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make secrets base directory configurable #4592

Merged
merged 1 commit into from
Jul 12, 2023
Merged

feat: Make secrets base directory configurable #4592

merged 1 commit into from
Jul 12, 2023

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Jun 7, 2023

Closes #4570

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

"make docker" on in this repo. In edgex-compose, modify add-security.yaml set EDGEX_SECRETS_ROOT to some other value. Make run dev and verify that the chmod applies to the new directory path, and defaults to /tmp/edgex/secrets if unset.

New Dependency Instructions (If applicable)

@bnevis-i bnevis-i requested a review from jim-wang-intel June 7, 2023 23:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.9% 11.9% Duplication

@bnevis-i
Copy link
Collaborator Author

bnevis-i commented Jun 7, 2023

@rk94655 is this acceptable to you?

jim-wang-intel
jim-wang-intel previously approved these changes Jun 8, 2023
View reviewed changes
lenny-goodell
lenny-goodell previously approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please open docs PR and link it in this PR

@bnevis-i bnevis-i dismissed stale reviews from lenny-goodell and jim-wang-intel via c1c4c63 July 12, 2023 03:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.7% 11.7% Duplication

@bnevis-i
Copy link
Collaborator Author

LGTM, please open docs PR and link it in this PR

Implementation changed to pull from existing configuration. No doc update needed. Please re-review.

@bnevis-i bnevis-i merged commit b4f3d37 into edgexfoundry:main Jul 12, 2023
@bnevis-i bnevis-i deleted the issue-4570 branch July 12, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rk94655 rk94655 rk94655 approved these changes

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@lenny-goodell lenny-goodell Awaiting requested review from lenny-goodell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make chown path in security-secretstore-setup startup.sh parameterizable.
4 participants
@bnevis-i @jim-wang-intel @lenny-goodell @rk94655