-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add env override capability for common configuration #4449
Conversation
closes edgexfoundry#4448 Signed-off-by: Leonard Goodell <[email protected]>
Signed-off-by: Leonard Goodell <[email protected]>
ef75d3a
to
09c0485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4449 +/- ##
=======================================
Coverage 41.73% 41.73%
=======================================
Files 106 106
Lines 9749 9749
=======================================
Hits 4069 4069
Misses 5333 5333
Partials 347 347 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Leonard Goodell <[email protected]>
a7264fc
to
adf2e47
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
As expected by #4448, the snap tests have started failing since this change because the overrides no longer apply on top of configurations coming from config provider: Need to change the snap tests to no longer test that. |
closes #4448
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)TBD
Testing Instructions
Run non-secure EdgeX stack
Build core-common-config from this branch
Set the following
run common config from command line
./core-common-config-bootstrapper -cp -cf configuration.yaml -o
verify consul has the appropriate overridden values
verify logs contain the following:
New Dependency Instructions (If applicable)