Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Consume watch for common Writable config changes #4432

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

lenny-goodell
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run make docker using this branch
Run non-secure EdgeX stack using compose builder make run no-secty dev
Verify the logs for all Core/Support services have the following:

"listening for private config changes"
"listening for all services common config changes"

In Consul change the common config all-service Writable/Telemetry/Interval to 15s
Verify the logs for all Core/Support service should the Telemetry Interval has changed

"Writeable configuration has been updated from the Configuration Provider"
"Telemetry interval has been updated. Processing new value..."
"Metrics Manager report interval changed to 15s"

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added the enhancement New feature or request label Mar 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
42.1% 42.1% Duplication

@lenny-goodell lenny-goodell added this to the Minnesota milestone Mar 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4432 (67a5401) into main (97ead1f) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4432   +/-   ##
=======================================
  Coverage   41.73%   41.73%           
=======================================
  Files         106      106           
  Lines        9749     9749           
=======================================
  Hits         4069     4069           
  Misses       5333     5333           
  Partials      347      347           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the test and it works as it specified.

@jim-wang-intel jim-wang-intel merged commit 043fa68 into edgexfoundry:main Mar 10, 2023
@lenny-goodell lenny-goodell deleted the consume-writable branch March 10, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants