refactor(snap): Remove explicit config provider addresses #4396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the current flags, the services (core-metadata, core-command, support-scheduler, support-notifications) don't get registered in Consul and don't produce any errors either.
There appear to be a bug either in the command processing of snapcraft or the EdgeX services. It appear that the
--registry
flag isn't processed at all. This PR is set as a refactoring type because the removed flag values are the defaults and theoretically equivalent.Another working solution was to change the order from
--configProvider consul.http://localhost:8500/ --registry
to--registry --configProvider consul.http://localhost:8500/
.If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Before:
After:
New Dependency Instructions (If applicable)