-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Push common config to config provider #4306
feat: Push common config to config provider #4306
Conversation
a70d845
to
76102cd
Compare
Signed-off-by: Elizabeth J Lee <[email protected]>
Signed-off-by: Elizabeth J Lee <[email protected]>
76102cd
to
7166e1e
Compare
Signed-off-by: Elizabeth J Lee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add the -cf=configuration.yaml
to CMD
in the Dockerfile
There are also some linter issues causing the build in the pipeline to fail
Signed-off-by: Elizabeth J Lee <[email protected]>
Signed-off-by: Elizabeth J Lee <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Elizabeth J Lee [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
make common-config
to ensure the binary buildsexport EDGEX_SECURITY_SECRET_STORE=false
make run no-secty
./core-common-config-bootstrapper -cp=consul.http://localhost:8500 -cf=configuration.yaml
make down
make docker
export EDGEX_SECURITY_SECRET_STORE=true
make run dev
cmd/core-common-config-bootstrapper
by runningsudo ./core-common-config-bootstrapper -cp=consul.http://localhost:8500 -cf=configuration.yaml
New Dependency Instructions (If applicable)