Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Push common config to config provider #4306

Merged
merged 5 commits into from
Jan 25, 2023

Conversation

ejlee3
Copy link
Contributor

@ejlee3 ejlee3 commented Jan 24, 2023

Signed-off-by: Elizabeth J Lee [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) - NA - added functionality to main
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) - docs will need to be added for common config when feature is complete

Testing Instructions

  1. run make common-config to ensure the binary builds
  2. run in non-secure mode export EDGEX_SECURITY_SECRET_STORE=false
  3. run edgex core services from compose builder make run no-secty
  4. ./core-common-config-bootstrapper -cp=consul.http://localhost:8500 -cf=configuration.yaml
  5. check that the config is loaded into Consul http://localhost:8500/ui/dc1/kv/edgex/v3/core-common-config-bootstrapper/
  6. bring down the services make down
  7. build the docker images make docker
  8. run in secure mode export EDGEX_SECURITY_SECRET_STORE=true
  9. use compose builder and run make run dev
  10. run the core common config bootstrapper from cmd/core-common-config-bootstrapper by running sudo ./core-common-config-bootstrapper -cp=consul.http://localhost:8500 -cf=configuration.yaml
  11. verify that the config is loaded into Consul

New Dependency Instructions (If applicable)

@ejlee3 ejlee3 force-pushed the common-config-pushing branch from a70d845 to 76102cd Compare January 24, 2023 22:38
@ejlee3 ejlee3 marked this pull request as ready for review January 24, 2023 22:45
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Show resolved Hide resolved
Signed-off-by: Elizabeth J Lee <[email protected]>
@ejlee3 ejlee3 force-pushed the common-config-pushing branch from 76102cd to 7166e1e Compare January 24, 2023 23:23
internal/core/common_config/main.go Outdated Show resolved Hide resolved
internal/core/common_config/main.go Outdated Show resolved Hide resolved
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jim-wang-intel
jim-wang-intel previously approved these changes Jan 25, 2023
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the -cf=configuration.yaml to CMD in the Dockerfile

There are also some linter issues causing the build in the pipeline to fail

Signed-off-by: Elizabeth J Lee <[email protected]>
Signed-off-by: Elizabeth J Lee <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 228e514 into edgexfoundry:main Jan 25, 2023
@farshidtz farshidtz mentioned this pull request Feb 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core Common Config Bootstrapper service - Implement pushing configuration
3 participants