-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable common security secret service metrics #4184
feat: Enable common security secret service metrics #4184
Conversation
dd329b6
to
5d8c1f7
Compare
@cloudxxx8 , the changes in go-mod-bootstrap used here some how have a negative impact on security bootstrapper. So please don't merge any dependabot PR for go-mod-bootstrap. |
Signed-off-by: Leonard Goodell <[email protected]>
default Signed-off-by: Leonard Goodell <[email protected]>
504b89a
to
f72fb8e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## main #4184 +/- ##
=======================================
Coverage 43.51% 43.51%
=======================================
Files 126 126
Lines 11149 11149
=======================================
Hits 4852 4852
Misses 5878 5878
Partials 419 419 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Leonard Goodell [email protected]
part of edgexfoundry/go-mod-bootstrap#374
also addresses edgexfoundry/go-mod-bootstrap#379
by using latest go-mod-bootstrap
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)feat: Document new common service metrics edgex-docs#877
Testing Instructions
Build docker images from this branch
Use compose builder run
make run dev
Verify all service bootstrap properly
Verify Core and Support service have the following log messages
From Consul, enable Debug logging on Core Metadata and enable the security metrics to be reported by setting the following to
true
Verify has the following log message every 30 secs
New Dependency Instructions (If applicable)