Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable common security secret service metrics #4184

Merged

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Oct 5, 2022

Signed-off-by: Leonard Goodell [email protected]

part of edgexfoundry/go-mod-bootstrap#374
also addresses edgexfoundry/go-mod-bootstrap#379
by using latest go-mod-bootstrap

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    feat: Document new common service metrics edgex-docs#877

Testing Instructions

Build docker images from this branch
Use compose builder run make run dev
Verify all service bootstrap properly
Verify Core and Support service have the following log messages

 "SecuritySecretsStored metric registered and will be reported (if enabled)"
"SecuritySecretsRequested metric registered and will be reported (if enabled)"

From Consul, enable Debug logging on Core Metadata and enable the security metrics to be reported by setting the following to true

edgex/core/2.0/core-metadata/Writable/Telemetry/Metrics/SecuritySecretsRequested
edgex/core/2.0/core-metadata/Writable/Telemetry/Metrics/SecuritySecretsStored

Verify has the following log message every 30 secs

"Publish 2 metrics to the 'edgex/telemetry/core-metadata' base topic"

New Dependency Instructions (If applicable)

@lenny-goodell
Copy link
Member Author

@cloudxxx8 , the changes in go-mod-bootstrap used here some how have a negative impact on security bootstrapper. So please don't merge any dependabot PR for go-mod-bootstrap.

jim-wang-intel
jim-wang-intel previously approved these changes Oct 6, 2022
@lenny-goodell lenny-goodell added the enhancement New feature or request label Oct 11, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Oct 11, 2022
bnevis-i
bnevis-i previously approved these changes Oct 11, 2022
@lenny-goodell lenny-goodell marked this pull request as ready for review October 11, 2022 17:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4184 (f72fb8e) into main (d47f91d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4184   +/-   ##
=======================================
  Coverage   43.51%   43.51%           
=======================================
  Files         126      126           
  Lines       11149    11149           
=======================================
  Hits         4852     4852           
  Misses       5878     5878           
  Partials      419      419           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lenny-goodell lenny-goodell merged commit 8629e80 into edgexfoundry:main Oct 11, 2022
@lenny-goodell lenny-goodell deleted the security-metrics-secrets branch October 11, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants