Fix: Delayed start services for support- services fail #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delayed start is not working for support services. Among other problems, for support services, the service key is support-servicename, but the service key in docker-compose is just servicename. Update pre-seeding script to account for this. Signed-off-by: Bryon Nevis <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
| device-bacnet device-camera device-grove device-modbus device-mqtt device-rest device-snmp \ | ||
| device-virtual device-rfid-llrp device-coap device-gpio \ | ||
| app-service-http-export app-service-mqtt-export app-service-sample app-rfid-llrp-inventory \ | ||
| app-service-external-mqtt-trigger; do | ||
| # Temporary workaround because service name in dockerfile is not consistent with service key. | ||
| # TAF scripts depend on legacy docker-compose service name. Fix in EdgeX 3.0. | ||
| service=`echo -n ${dockerservice} | sed -e 's/app-service-/app-/'` | ||
| service=`echo -n ${dockerservice} | sed -e 's/app-service-/app-/'` | ||
| # support- services have the opposite problem. service key is right, service name in docker isn't |
There was a problem hiding this comment.
Same issue with the core services. Service name is data while the service key is `core-data'. Something we need to clean-up in EdgeX 3.0. I have update this issue to cover App, Core and Support service names.
edgexfoundry/edgex-compose#231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delayed start is not working for support services. Among other problems, for support services,
the service key is support-servicename,
but the service key in docker-compose is just servicename.
Update pre-seeding script to account for this.
Signed-off-by: Bryon Nevis [email protected]
Closes #4152
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
(Update later with related edgex-compose change.)
New Dependency Instructions (If applicable)