Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add option to build Core/Support services with NATS Capability #4137

Merged
merged 1 commit into from
Aug 31, 2022
Merged

build: Add option to build Core/Support services with NATS Capability #4137

merged 1 commit into from
Aug 31, 2022

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Aug 29, 2022 •
edited
Loading

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) ** README updated**

Testing Instructions

Run the following commands and verify each Go build step includes -tags "include_nats_messaging ...

make build-nats
make docker-nats

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added enhancement New feature or request build labels Aug 29, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Aug 29, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

jim-wang-intel
jim-wang-intel approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 604c3c9 into edgexfoundry:main Aug 31, 2022
@lenny-goodell lenny-goodell deleted the nats-build branch August 31, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@AlexCuse AlexCuse Awaiting requested review from AlexCuse

@cloudxxx8 cloudxxx8 Awaiting requested review from cloudxxx8

@ernestojeda ernestojeda Awaiting requested review from ernestojeda

@JamesKButcher JamesKButcher Awaiting requested review from JamesKButcher

@jpwhitemn jpwhitemn Awaiting requested review from jpwhitemn

Assignees
No one assigned
Labels
build enhancement New feature or request
Projects
None yet
Milestone
Levski
Development

Successfully merging this pull request may close these issues.
2 participants
@lenny-goodell @jim-wang-intel