Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snap): add secretstore token for camera snaps #4034

Merged
merged 4 commits into from
May 23, 2022

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented May 23, 2022

Signed-off-by: Mengyi Wang [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

- device-usb-camera snap
- device-onvif-camera snap

Signed-off-by: Mengyi Wang <[email protected]>
Parts 'kuiper' and 'postgres' have some files with same file name, but with different contents

Signed-off-by: Mengyi Wang <[email protected]>
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@MonicaisHer MonicaisHer force-pushed the cameras-addon-services branch from ef2c9b4 to 9c42764 Compare May 23, 2022 09:17
@MonicaisHer
Copy link
Contributor Author

This PR will be rebased after #4035 has been merged.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #4034 (9c42764) into main (87560f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4034   +/-   ##
=======================================
  Coverage   47.20%   47.20%           
=======================================
  Files         114      114           
  Lines        9832     9832           
=======================================
  Hits         4641     4641           
  Misses       4804     4804           
  Partials      387      387           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87560f2...9c42764. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MonicaisHer MonicaisHer marked this pull request as ready for review May 23, 2022 14:59
@farshidtz farshidtz merged commit 6f84e70 into edgexfoundry:main May 23, 2022
farshidtz pushed a commit to farshidtz/edgex-go that referenced this pull request May 23, 2022
…undry#4034)

- device-usb-camera snap
- device-onvif-camera snap

Signed-off-by: Mengyi Wang <[email protected]>
(cherry picked from commit 6f84e70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants