Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make support services include spiffe in buildtime from Makefile #3969

Conversation

jim-wang-intel
Copy link
Contributor

  • Add another variable flag for support serivces in makefile
  • make support services use the default enabled delayed start in build time

Closes: #3968

Signed-off-by: Jim Wang [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • [x ] I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • [x ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

run make build to see the size difference on the built images.

New Dependency Instructions (If applicable)

@jim-wang-intel jim-wang-intel added enhancement New feature or request 1-low priority denoting isolated changes build labels Apr 14, 2022
@jim-wang-intel jim-wang-intel self-assigned this Apr 14, 2022
@jim-wang-intel jim-wang-intel changed the title feat: Make support serives include spiffe in buildtime from Makefile feat: Make support services include spiffe in buildtime from Makefile Apr 14, 2022
@jim-wang-intel jim-wang-intel force-pushed the include-spiffe-for-support-by-default branch from 573d8fb to b0badd4 Compare April 14, 2022 16:32
- Add another variable flag for support services in makefile
- make support services use the default enabled delayed start in build time

Closes: edgexfoundry#3968

Signed-off-by: Jim Wang <[email protected]>
@jim-wang-intel jim-wang-intel force-pushed the include-spiffe-for-support-by-default branch from b0badd4 to 60964b6 Compare April 14, 2022 16:37
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
bnevis-i
bnevis-i previously approved these changes Apr 14, 2022
Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Lenny's suggestion, builds and runs successfully.

@codecov-commenter
Copy link

Codecov Report

Merging #3969 (60964b6) into main (0fc989a) will increase coverage by 0.15%.
The diff coverage is 76.40%.

@@            Coverage Diff             @@
##             main    #3969      +/-   ##
==========================================
+ Coverage   46.98%   47.13%   +0.15%     
==========================================
  Files         112      113       +1     
  Lines        9759     9820      +61     
==========================================
+ Hits         4585     4629      +44     
- Misses       4787     4804      +17     
  Partials      387      387              
Impacted Files Coverage Δ
internal/core/data/application/app.go 34.61% <34.61%> (ø)
internal/core/data/application/event.go 61.90% <75.00%> (+0.30%) ⬆️
internal/core/data/controller/http/event.go 84.18% <100.00%> (+0.18%) ⬆️
internal/core/data/messaging/messaging.go 86.20% <100.00%> (ø)
...nal/core/metadata/controller/http/devicecommand.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af1624...60964b6. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim-wang-intel jim-wang-intel merged commit efde56b into edgexfoundry:main Apr 15, 2022
@jim-wang-intel jim-wang-intel deleted the include-spiffe-for-support-by-default branch April 15, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-low priority denoting isolated changes build enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make support services build to include spiffe by default in Makefile
4 participants