-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make support services include spiffe in buildtime from Makefile #3969
feat: Make support services include spiffe in buildtime from Makefile #3969
Conversation
573d8fb
to
b0badd4
Compare
- Add another variable flag for support services in makefile - make support services use the default enabled delayed start in build time Closes: edgexfoundry#3968 Signed-off-by: Jim Wang <[email protected]>
b0badd4
to
60964b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Lenny's suggestion, builds and runs successfully.
Codecov Report
@@ Coverage Diff @@
## main #3969 +/- ##
==========================================
+ Coverage 46.98% 47.13% +0.15%
==========================================
Files 112 113 +1
Lines 9759 9820 +61
==========================================
+ Hits 4585 4629 +44
- Misses 4787 4804 +17
Partials 387 387
Continue to review full report at Codecov.
|
Signed-off-by: Jim Wang <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #3968
Signed-off-by: Jim Wang [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
run
make build
to see the size difference on the built images.New Dependency Instructions (If applicable)