Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): Add secret store config for delayed start #3948

Merged
merged 1 commit into from
Apr 19, 2022
Merged

feat(security): Add secret store config for delayed start #3948

merged 1 commit into from
Apr 19, 2022

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Apr 7, 2022

Signed-off-by: Bryon Nevis [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

In compose scripts, make run delayed-start

New Dependency Instructions (If applicable)

@bnevis-i
Copy link
Collaborator Author

bnevis-i commented Apr 7, 2022

@jpwhitemn Example of the boilerplate for delayed start services
@jim-wang-intel Please make sure I got this correct (do we want to default localhost like everything else?)

@jim-wang-intel
Copy link
Contributor

jim-wang-intel commented Apr 7, 2022

@jpwhitemn Example of the boilerplate for delayed start services @jim-wang-intel Please make sure I got this correct (do we want to default localhost like everything else?)

@bnevis-i / @jpwhitemn :
Format and naming-wise are correct; but i do have a question: do we need to make these configuration for all-core-services as I thought they don't do delayed-start (like core-data, for example)?

@bnevis-i
Copy link
Collaborator Author

bnevis-i commented Apr 7, 2022

@jpwhitemn Example of the boilerplate for delayed start services @jim-wang-intel Please make sure I got this correct (do we want to default localhost like everything else?)

@bnevis-i / @jpwhitemn : Format and naming-wise are correct; but i do have a question: do we need to make these configuration for all-core-services as I thought they don't do delayed-start (like core-data, for example)?

The point of the exercise is that we make the configuration visible, even if we don't intend to enable it at this point.

@bnevis-i bnevis-i marked this pull request as draft April 18, 2022 22:46
@bnevis-i bnevis-i marked this pull request as ready for review April 19, 2022 15:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.2% 7.2% Duplication

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i bnevis-i merged commit 6b188fc into edgexfoundry:main Apr 19, 2022
@bnevis-i bnevis-i deleted the delayed-start-config branch April 19, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants