Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): Enable security-hardened go binaries for cgo flags #3893

Merged

Conversation

jim-wang-intel
Copy link
Contributor

Add hardening CGO flags for go binaries

Fixes: #3880

Signed-off-by: Jim Wang [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • [X ] I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) just the build related changes for security hardening
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) just the build related changes for security hardening

Testing Instructions

New Dependency Instructions (If applicable)

Add hardening CGO flags for go binaries

Fixes: edgexfoundry#3880

Signed-off-by: Jim Wang <[email protected]>
@jim-wang-intel jim-wang-intel added enhancement New feature or request core-services 1-low priority denoting isolated changes labels Mar 8, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jim-wang-intel
Copy link
Contributor Author

Address PR comment from another PR: #3892 (comment)

@bnevis-i bnevis-i merged commit 7a57317 into edgexfoundry:main Mar 23, 2022
@jim-wang-intel jim-wang-intel deleted the security-hardened-cgo-3880 branch July 29, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-low priority denoting isolated changes core-services enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable security-hardened go binaries (when cgo enabled)
2 participants