-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snap): add secretstore token for edgex-ekuiper snap #3888
feat(snap): add secretstore token for edgex-ekuiper snap #3888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a feature addition. Please change the PR title prefix.
Also, the commits need to have semantic prefixes.
b6f7f62
to
23cfcde
Compare
42b2064
to
a119cc7
Compare
The Vault token is required for the standalone deployment of eKuiper with snap, where a script queries the Redis credentials after authenticating with Vault. Signed-off-by: Mengyi Wang <[email protected]>
a119cc7
to
13d2675
Compare
Kudos, SonarCloud Quality Gate passed! |
eKuiper doesn't use |
@lenny-intel, the embedded eKuiper doesn't. This is for a standalone ekuiper snap. I've just updated the PR description to:
The standalone edgex-ekuiper snap is work in progress. But we are almost sure that using the vault token to query the redis credentials is the cleanest way forward. This makes the edgex-ekuiper's server configurations (mostly unrelated to security) decoupled from an internal security component of EdgeX. Moreover, this makes edgex-ekuiper's interaction with the platform similar to other services. I think we could eventually have a component which does this both for snapped and dockerized ekuiper. For example an edgex-ekuiper-setup app that takes a vault token and config file templates, queries the redis credentials, and outputs the config files. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds edgex-ekuiper as an add-on service to
secretStoreTokens
andsecretStoreKnownSecrets
(for redisdb) lists.The Vault token is required for the standalone deployment of eKuiper with snap, where a script queries the Redis credentials after authenticating with Vault. The snap receives the vault token using the
edgex-secretstore-token
content interface or via other means.Signed-off-by: Mengyi Wang [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)