Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to latest go-mod-messaging w/o ZMQ on windows #3833

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

lenny-goodell
Copy link
Member

BREAKING CHANGE: ZeroMQ no longer supported on native Windows for EdgeX
MessageBus

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A for Build PR
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A for Build PR
  • I have opened a PR for the related docs change (if not, why?) N/A for Build PR

Testing Instructions

N/A for Build PR

New Dependency Instructions (If applicable)

N/A for Build PR

BREAKING CHANGE: ZeroMQ no longer supported on native Windows for EdgeX
MessageBus

Signed-off-by: Leonard Goodell <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lenny-goodell lenny-goodell added this to the Kamakura milestone Nov 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3833 (fbe562c) into main (23881e6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3833   +/-   ##
=======================================
  Coverage   45.77%   45.77%           
=======================================
  Files         112      112           
  Lines        9640     9640           
=======================================
  Hits         4413     4413           
  Misses       4844     4844           
  Partials      383      383           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23881e6...fbe562c. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 240e6fd into edgexfoundry:main Nov 29, 2021
@lenny-goodell lenny-goodell deleted the no-win-zmq branch November 29, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants