Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename Encode func to better name #3822

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

lenny-goodell
Copy link
Member

Function also writes response.

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A for name refactoring
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A for name refactoring
  • I have opened a PR for the related docs change (if not, why?) N/A for name refactoring

Testing Instructions

N/A for name refactoring

New Dependency Instructions (If applicable)

N/A for name refactoring

@lenny-goodell
Copy link
Member Author

recheck

2 similar comments
@lenny-goodell
Copy link
Member Author

recheck

@lenny-goodell
Copy link
Member Author

recheck

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #3822 (c69b39d) into main (0e57188) will not change coverage.
The diff coverage is 98.91%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3822   +/-   ##
=======================================
  Coverage   45.77%   45.77%           
=======================================
  Files         112      112           
  Lines        9640     9640           
=======================================
  Hits         4413     4413           
  Misses       4844     4844           
  Partials      383      383           
Impacted Files Coverage Δ
internal/pkg/utils/http.go 28.08% <0.00%> (ø)
internal/core/command/controller/http/command.go 97.33% <100.00%> (ø)
internal/core/data/controller/http/event.go 85.45% <100.00%> (ø)
internal/core/data/controller/http/reading.go 85.87% <100.00%> (ø)
internal/core/metadata/controller/http/device.go 94.37% <100.00%> (ø)
...nal/core/metadata/controller/http/deviceprofile.go 86.25% <100.00%> (ø)
...al/core/metadata/controller/http/deviceresource.go 100.00% <100.00%> (ø)
...nal/core/metadata/controller/http/deviceservice.go 97.19% <100.00%> (ø)
.../core/metadata/controller/http/provisionwatcher.go 93.61% <100.00%> (ø)
...port/notifications/controller/http/notification.go 84.40% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e57188...c69b39d. Read the comment docs.

closes edgexfoundry#2753

Function also writes response.

Signed-off-by: Leonard Goodell <[email protected]>
Copy link
Member

@weichou1229 weichou1229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.5% 9.5% Duplication

@cloudxxx8 cloudxxx8 merged commit b2bbeb2 into edgexfoundry:main Nov 25, 2021
farshidtz pushed a commit to farshidtz/edgex-go that referenced this pull request Nov 30, 2021
closes edgexfoundry#2753

Function also writes response.

Signed-off-by: Leonard Goodell <[email protected]>

Co-authored-by: Cloud Tsai <[email protected]>
@lenny-goodell lenny-goodell deleted the encode-rename branch May 16, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the pkg.Encode func name more meaningful
4 participants