-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data): new API to search Readings by multiple resource names #3766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rebased and update go.mod, go.sum to pick up the latest version of go-mod-core-contracts. |
Add a new Get API that will accept multiple resource names in the payload as the query criteria. /reading/device/name/{deviceName}/start/{start}/end/{end} the query payload would be: { "resourceNames": ["r1", "r2", "r3"] } If the resourceNames or the payload is empty, return all the Readings meet the deviceName and in the start/end timestamp Unit tests are added and openapi doc is updated Signed-off-by: Jude Hung <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## main #3766 +/- ##
==========================================
- Coverage 46.21% 45.99% -0.22%
==========================================
Files 112 112
Lines 9479 9583 +104
==========================================
+ Hits 4381 4408 +27
- Misses 4718 4794 +76
- Partials 380 381 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a new Get API that will accept multiple resource names in the payload as the query criteria.
GET /reading/device/name/{deviceName}/start/{start}/end/{end}
the query payload would be:
{
"resourceNames": ["r1", "r2", "r3"]
}
If the resourceNames or the payload is empty, return all the Readings meet the deviceName and in the start/end timestamp
Signed-off-by: Jude Hung [email protected]
closes #3693
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
GET reading/device/name/{deviceName}/start/{start}/end/{end}
New Dependency Instructions (If applicable)