feat: Validate Interval and IntervalAction before loading from config #3646
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3646 +/- ##
=======================================
Coverage 47.29% 47.29%
=======================================
Files 112 112
Lines 9174 9174
=======================================
Hits 4339 4339
Misses 4462 4462
Partials 373 373 Continue to review full report at Codecov.
|
| Name: configuration.Intervals[i].Name, | ||
| Start: configuration.Intervals[i].Start, | ||
| End: configuration.Intervals[i].End, | ||
| Interval: configuration.Intervals[i].Interval, | ||
| } | ||
| validateErr := common.Validate(dto) | ||
| if validateErr != nil { | ||
| return errors.NewCommonEdgeXWrapper(validateErr) |
There was a problem hiding this comment.
wrap the error with the proper error message:
validate pre-defined Interval %s from configuration failed , dto.Name
| _, err := dbClient.IntervalActionByName(action.Name) | ||
| validateErr := common.Validate(dto) | ||
| if validateErr != nil { | ||
| return errors.NewCommonEdgeXWrapper(validateErr) |
There was a problem hiding this comment.
wrap the error with the proper error message:
validate pre-defined IntervalAction %s from configuration failed , dto.Name
Interval and IntervalAction should be created as a DTO, and call validate() to ensure the data is valid. Close: #3642 Signed-off-by: weichou <[email protected]>
Close: #3642 Signed-off-by: weichou <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Close: #3642
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #3642
What is the new behavior?
Interval and IntervalAction should be created as a DTO, and call validate() to ensure the data is valid.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information