feat: Implement V2 API to query readings by name and time range #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened PR to add API route constant edgexfoundry/go-mod-core-contracts#635 |
|
this is for v2.0.1, so hold this PR until v2.0.0 released |
|
@weichou1229 please rebase this PR and use the new contract version |
Implement V2 API to query readings by resourceName and specified time range Close: #3519 Signed-off-by: weichou <[email protected]>
Close: #3519 Signed-off-by: weichou <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Rebased and upgraded the contract version to v2.0.1-dev.1 |
Codecov Report
@@ Coverage Diff @@
## main #3577 +/- ##
==========================================
- Coverage 47.29% 47.27% -0.03%
==========================================
Files 111 111
Lines 9013 9048 +35
==========================================
+ Hits 4263 4277 +14
- Misses 4380 4401 +21
Partials 370 370
Continue to review full report at Codecov.
|
lenny-goodell
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3519
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number: #3519
What is the new behavior?
Implement V2 API to query readings by resourceName and specified time range
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information