feat(security)!: Deprecate oauth2 auth method #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested changes
Jun 16, 2021
Deprecates oauth2 proxy auth method in favor of stronger JWT-based auth method by removing ability for secrets-config utility to create OAuth2 users. security-proxy-setup accidentally broke OAuth2 functionality by installing a global JWT auth handler intended to secure admin API (can't have two global auth handlers because both auth methods must pass, which is impossible.) Comment rather than remove code in case it needs to be added back in Jakarta stabilization release, otherwise will be removed permanently in both secrets-config and proxy-setup. Closes #3564 Signed-off-by: Bryon Nevis <[email protected]>
Comments added. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates oauth2 proxy auth method
in favor of stronger JWT-based auth method
by removing ability for secrets-config utility
to create OAuth2 users.
security-proxy-setup accidentally broke
OAuth2 functionality by installing a global
JWT auth handler intended to secure admin API
(can't have two global auth handlers because
both auth methods must pass, which is impossible.)
Comment rather than remove code in case
it needs to be added back in Jakarta
stabilization release, otherwise will be
removed permanently in both secrets-config
and proxy-setup.
Closes #3564
Signed-off-by: Bryon Nevis [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
When adding proxy users with oauth2 auth method, Kong proxy authentication broken
due to installation of two global auth handlers.
Issue Number:
Closes #3564
What is the new behavior?
Remove oauth2-based authentication.
Does this PR introduce a breaking change?
OAuth2 was the default in Edinburgh preview security release.
JWT has been the default since Fuji release.
OAuth2 has been supported as a JWT alternative since Fuji.
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information