feat(security): Implement consul token header in API Gateway #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
added
enhancement
jim-wang-intel
requested review from
beaufrusetta,
hutchic,
tonyespy,
cloudxxx8,
bnevis-i,
lenny-goodell and
siggiskulason
jim-wang-intel
changed the title
jim-wang-intel
force-pushed
the
implement-consul-token-header-proxy
branch
from
26176fb to
3daad41
Compare
lenny-goodell
requested changes
Apr 21, 2021
cmd/security-bootstrapper/entrypoint-scripts/kong_wait_install.sh
Outdated
Show resolved
Hide resolved
bnevis-i
reviewed
Apr 21, 2021
bnevis-i
reviewed
Apr 21, 2021
bnevis-i
reviewed
Apr 21, 2021
bnevis-i
reviewed
Apr 21, 2021
jim-wang-intel
force-pushed
the
implement-consul-token-header-proxy
branch
from
3daad41 to
435fc41
Compare
3 tasks
jim-wang-intel
force-pushed
the
implement-consul-token-header-proxy
branch
from
435fc41 to
88d5918
Compare
|
rebased against master and removed the previous beaus' commit; now it only contains the stuff for adding consul route and header into Kong. |
- Add implementation for enabling request transformer plugin on consul service for Kong's route through proxy-setup - Fix unit test issues - Add necessary starting sequence and env. for proxy-setup in snap packaging Closes: edgexfoundry#3368 Signed-off-by: Jim Wang <[email protected]>
Signed-off-by: Jim Wang <[email protected]>
jim-wang-intel
force-pushed
the
implement-consul-token-header-proxy
branch
from
88d5918 to
534e16a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lenny-goodell
approved these changes
May 5, 2021
bnevis-i
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
no consul service available in Kong
Issue Number: #3368
What is the new behavior?
add consul service/route to Kong and enable consul header through kong's request transform plugins on the added consul service.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Note: This has been
re-basedon top of @beaufrusetta's branch from his PR #3328Would need some merging coordination with his PR: until then, made this PR as draft.
Beau's PR has already merged, updated to fit only commits I've now.
Other information