Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hanoi - Upgrade to go-mod-messaging with ZMQ fix for Hanoi #3084

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

Hanoi branch doesn't have ZMQ bug fix via go-mod-messaging

Issue Number: 3083

What is the new behavior?

Hanoi branch now has ZMQ bug fix via go-mod-messaging v0.1.30

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell
Copy link
Member Author

recheck

jpwhitemn
jpwhitemn previously approved these changes Jan 27, 2021
@lenny-goodell lenny-goodell linked an issue Jan 28, 2021 that may be closed by this pull request
@lenny-goodell lenny-goodell changed the title fix: Upgrade to go-mod-messaging with ZMQ fix for Hanoi fix: Hanoi - Upgrade to go-mod-messaging with ZMQ fix for Hanoi Jan 28, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@tonyespy tonyespy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tonyespy tonyespy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try again

@lenny-goodell lenny-goodell merged commit 9a6eedb into edgexfoundry:hanoi Jan 28, 2021
@lenny-goodell lenny-goodell deleted the hanoi-zmq-fix branch January 28, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Hanoi) Backport ZMQ bug fix to Hanoi branch
3 participants