Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use latest bootstrap for logging client changes #2975

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

core-contract and bootstrap modules have been update to:

  • Remote and file logging have been removed
  • Factory method signature has changed.

Issue Number: #2974

What is the new behavior?

Using latest core-contract and bootstrap
Update single call to Logging Client factory method

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Remote and file logging have been removed

closes edgexfoundry#2974

Signed-off-by: lenny <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lenny-goodell lenny-goodell merged commit f96f7b9 into edgexfoundry:master Dec 29, 2020
@lenny-goodell lenny-goodell deleted the logging-client branch December 29, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest Logging client for removal of remote and file logging
2 participants