Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-data): Event ID has to be pre-populated #2695

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Sep 16, 2020

Signed-off-by: Cloud Tsai [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit subject follows the Conventional Commits spec
  • The commit message follows the EdgeX Contributor Guide
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • make test has completed successfully

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Event ID will be generated before storing into the database

Issue Number: Fix #2684

What is the new behavior?

In V2 API, Event ID has to be UUID and pre-populated.
Adopt the latest go-mod-contracts to include this validation.
Modify the related unit test to verify this feature.
Remove the UUID assignment before storing into the database.
Remove checksum and correlation id from Event model.

Does this PR introduce a breaking change?

  • Yes
  • No

In V2 API, Event ID has to be UUID and pre-populated.
Adopt the latest go-mod-contracts to include this validation.
Modify the related unit test to verify this feature.
Remove the UUID assignment before storing into the database.
Remove checksum and correlation id from Event model.
Fix edgexfoundry#2684

Signed-off-by: Cloud Tsai <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 470d176 into edgexfoundry:master Sep 16, 2020
@cloudxxx8 cloudxxx8 deleted the issue-2684 branch September 21, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-populate the event ID with a UUID
2 participants