Adding vault config default env var and allowing setting VAULT_LOCAL_… #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-intel
force-pushed
the
vault_config
branch
3 times, most recently
from
6c8211a to
c580342
Compare
This allows setting VAULT_LOCAL_CONFIG variable from the compose file. This was useful in edgexfoundry/edgex-examples#7 to allow edgex to run in docker swarm because 'mlock' needed to be disabled in the configuration. Signed-off-by: adam-w-mitchell <[email protected]>
adam-intel
force-pushed
the
vault_config
branch
from
c580342 to
9abc40e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bnevis-i
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding vault config default env var and allowing setting VAULT_LOCAL_CONFIG variable from the compose file.
PR Checklist
Please check if your PR fulfills the following requirements:
make testhas completed successfullyPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
edgexfoundry/edgex-docs#135
What is the new behavior?
Enables environment variable override of vault configuration.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information