Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix path dependency in tokenprovider_linux_test.go #2641

Merged
merged 2 commits into from
Jul 24, 2020
Merged

fix: Fix path dependency in tokenprovider_linux_test.go #2641

merged 2 commits into from
Jul 24, 2020

Conversation

bnevis-i
Copy link
Collaborator

Unit test fails in apline builder

Fixes #2640

Signed-off-by: Bryon Nevis [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit subject follows the Conventional Commits spec
  • The commit message follows the EdgeX Contributor Guide
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • make test has completed successfully

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #2640

What is the new behavior?

Fix allows system path to be searched for touch tool

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Unit test fails in apline builder

Signed-off-by: Bryon Nevis <[email protected]>
@bnevis-i bnevis-i added the bug Something isn't working label Jul 24, 2020
@bnevis-i bnevis-i added this to the Hanoi milestone Jul 24, 2020
@bnevis-i bnevis-i requested a review from ernestojeda July 24, 2020 00:46
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bnevis-i bnevis-i merged commit 0478457 into edgexfoundry:master Jul 24, 2020
@bnevis-i bnevis-i deleted the issue-2640 branch July 24, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test fails in golang:1.13-alpine due to path assumption
3 participants