feat: Add config setting for value used for ListenAndServe #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated to latest go-mod-bootstrap v0.0.36 - Added Service.ServerBindAddr setting to config files for all services Signed-off-by: Felix Ting <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Validate branch using local |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2624
Signed-off-by: Felix Ting [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
make testhas completed successfullyPR Type
What kind of change does this PR introduce?
What is the current behavior?
Before go-mo-bootstrap v0.0.36, the ListenAndServe IP address defaults to binding to an all-interface listener value of 0.0.0.0
Issue Number: #2624
What is the new behavior?
Added a Service.
ServerBindAddrconfigurable value to config file to reflect this change: edgexfoundry/go-mod-bootstrap#84The default value of
ServerBindAddrof each service is blank, so the Service.Hostvalue is now the ListenAndServe IP address. However, it allows env override to set a specific value as needed for different deployments.Does this PR introduce a breaking change?