-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removed client monitoring #2595
Conversation
Does the affect consul's reporting whether the service is healthy or not? |
Nope. Just removes services asking Consul for the current URL for a dependent service. |
closes edgexfoundry#2594 Signed-off-by: lenny <[email protected]>
93bef34
to
2ea1893
Compare
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
==========================================
+ Coverage 38.87% 38.97% +0.09%
==========================================
Files 145 145
Lines 12826 12671 -155
==========================================
- Hits 4986 4938 -48
+ Misses 7560 7459 -101
+ Partials 280 274 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
#1723 PR Checklist
Please check if your PR fulfills the following requirements:
make test
has completed successfullyPR Type
What kind of change does this PR introduce?
What is the current behavior?
For each depend service, each Service pings Consul every 15 seconds to get the latest URL which never changes.
Issue Number: #2594
What is the new behavior?
No longer monitor the client URLs. Just set the url went Client is created and use it.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information