-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add call to Message Bus Connect() #2467
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2467 +/- ##
==========================================
- Coverage 38.25% 38.21% -0.04%
==========================================
Files 153 153
Lines 12583 12594 +11
==========================================
Hits 4813 4813
- Misses 7513 7524 +11
Partials 257 257
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add logic for calling the Disconnect
method on the client as well. During testing these changes I noticed that the MQTT server is reporting that the client did not properly disconnect.
Great catch. I will add this. THX! |
Core data was missing call to connect to message bus and needed latest go-mod-messging for MQTT Message Bus to work. closes edgexfoundry#2466 Signed-off-by: lenny <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@AnthonyMBonafide , disconnect code has been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I verified these changes manually with a locally running MQTT Mosquitto server.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Core data fails to publish to MQTT MessageBus due to not being connected.
Issue Number: #2466
What is the new behavior?
Core data successfully publishes to MQTT MessageBus.
Does this PR introduce a breaking change?
Are there any specific instructions or things that should be known prior to reviewing?
Other information