Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm deployment: Expose services on a per-service basis #161

Closed
bnevis-i opened this issue Dec 7, 2022 · 0 comments · Fixed by #169
Closed

helm deployment: Expose services on a per-service basis #161

bnevis-i opened this issue Dec 7, 2022 · 0 comments · Fixed by #169
Labels
enhancement New feature or request

Comments

@bnevis-i
Copy link
Collaborator

bnevis-i commented Dec 7, 2022

🚀 Feature Request

Relevant Package [REQUIRED]

helm chart

Description [REQUIRED]

The current helm chart has the following stanza

expose:
  # Option value: ClusterIP/NodePort/LoadBalancer
  type: ClusterIP

This sets the service type for all "service" resources in the chart.

Describe the solution you'd like

This setting is not granular enough. It should be possible to set the service type on a per-service basis, with ClusterIP as the default for internal services, and NodePort as the default for externally-visible services such as consul and edgex-ui.

See also #160 which relates to hostPort exposure of EdgeX services.
@bnevis-i bnevis-i added the enhancement New feature or request label Dec 7, 2022
@bnevis-i bnevis-i linked a pull request Dec 15, 2022 that will close this issue
feat: Expose services on a per-service basis #169
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Expose services on a per-service basis drkfmorton/edgex-examples
1 participant
@bnevis-i