feat: Upgrade core-contracts lib to use redesigned device profile #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 31.56% 31.36% -0.20%
==========================================
Files 33 33
Lines 2265 2257 -8
==========================================
- Hits 715 708 -7
+ Misses 1497 1496 -1
Partials 53 53
Continue to review full report at Codecov.
|
cloudxxx8
requested changes
Mar 15, 2021
| - { deviceResource: "SwitchButton" } | ||
| set: | ||
| - { deviceResource: "SwitchButton", parameter: "false" } | ||
| readWrite: "W" |
| @@ -81,7 +81,7 @@ RetryWaitPeriod = "1s" | |||
| [[DeviceList.AutoEvents]] | |||
| Frequency = '10s' | |||
| OnChange = false | |||
| SourceName = 'Switch' | |||
| SourceName = 'SwitchButton' | |||
There was a problem hiding this comment.
You don't need to make this change if it is RW
cloudxxx8
reviewed
Mar 15, 2021
openapi/v2/device-sdk.yaml
Outdated
| type: integer | ||
| description: "A Unix timestamp indicating when the object was last modified" | ||
| description: | ||
| apiVersion: |
There was a problem hiding this comment.
apiVersion will only be in request, response, and event
There was a problem hiding this comment.
Removed the apiVersion from the device profile schema.
|
@weichou1229 please help resolve the conflict |
Upgrade core-contracts lib to apply the v2 device profile changes: - Upgrade core-contracts lib to use the redesigned device profile - Update swagger file Close #815 Signed-off-by: weichou <[email protected]>
Close #815 Signed-off-by: weichou <[email protected]>
|
Rebased and resolved the conflict. |
AlexCuse
pushed a commit
to Technotects/device-sdk-go
that referenced
this pull request
Mar 30, 2021
…gexfoundry#816) * feat: Upgrade core-contracts lib to use redesigned device profile Upgrade core-contracts lib to apply the v2 device profile changes: - Upgrade core-contracts lib to use the redesigned device profile - Update swagger file Close edgexfoundry#815 Signed-off-by: weichou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #815
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/master/.github/CONTRIBUTING.md
What is the current behavior?
Issue Number: #815
What is the new behavior?
Upgrade core-contracts lib to apply the v2 device profile changes:
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Other information