Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to use generic Event tags #969

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

lenny-goodell
Copy link
Member

closes #959

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) Unit tests are sufficient
  • I have opened a PR for the related docs change (if not, why?)
    feat: Document NewGenericTags factory func edgex-docs#607

Testing Instructions

n/a

New Dependency Instructions (If applicable)

n/a

@codecov-commenter
Copy link

Codecov Report

Merging #969 (64be8ec) into main (3697d04) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #969      +/-   ##
==========================================
+ Coverage   67.07%   67.15%   +0.07%     
==========================================
  Files          33       33              
  Lines        2536     2542       +6     
==========================================
+ Hits         1701     1707       +6     
  Misses        735      735              
  Partials      100      100              
Impacted Files Coverage Δ
internal/app/configurable.go 72.60% <100.00%> (ø)
pkg/transforms/tags.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3697d04...64be8ec. Read the comment docs.

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 83cc0a2 into edgexfoundry:main Oct 13, 2021
FelixTing pushed a commit to FelixTing/app-functions-sdk-go that referenced this pull request Mar 3, 2022
@lenny-goodell lenny-goodell deleted the tags branch May 16, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable tags pipeline function for new generic type
3 participants