feat(sdk): Custom Trigger Multi-Pipeline Support #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCuse
force-pushed
the
custom-trigger-support-multiple-pipelines
branch
2 times, most recently
from
c81260c to
38ed098
Compare
Codecov Report
@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 66.16% 65.54% -0.62%
==========================================
Files 33 33
Lines 2503 2525 +22
==========================================
- Hits 1656 1655 -1
- Misses 748 771 +23
Partials 99 99
Continue to review full report at Codecov.
|
AlexCuse
force-pushed
the
custom-trigger-support-multiple-pipelines
branch
from
38ed098 to
b21662f
Compare
lenny-goodell
requested changes
Sep 10, 2021
AlexCuse
force-pushed
the
custom-trigger-support-multiple-pipelines
branch
2 times, most recently
from
29bcd0b to
1647a4e
Compare
lenny-goodell
requested changes
Sep 10, 2021
AlexCuse
force-pushed
the
custom-trigger-support-multiple-pipelines
branch
2 times, most recently
from
dafe690 to
034717c
Compare
Add service.processMessageOnRuntime to use default pipeline if configured or attempt to use topic matching logic. Deprecate TriggerMessageProcessor and TriggerContextBuilder and inline the existing functions on TriggerConfig as the approach used there will not work with multiple pipelines. Replace with MessageProcessor that only takes the message envelope and builds context(s) as needed. Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse
force-pushed
the
custom-trigger-support-multiple-pipelines
branch
from
034717c to
4d23791
Compare
FelixTing
pushed a commit
to FelixTing/app-functions-sdk-go
that referenced
this pull request
Mar 3, 2022
Add service.processMessageOnRuntime to use default pipeline if configured or attempt to use topic matching logic. Deprecate TriggerMessageProcessor and TriggerContextBuilder and inline the existing functions on TriggerConfig as the approach used there will not work with multiple pipelines. Replace with MessageProcessor that only takes the message envelope and builds context(s) as needed. Signed-off-by: Alex Ullrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add service.processMessageOnRuntime to use default pipeline if configured or attempt to use topic matching logic. Deprecate TriggerMessageProcessor and TriggerContextBuilder and inline the existing functions on TriggerConfig as the approach used there will not work with multiple pipelines. Replace with MessageProcessor that only takes the message envelope and builds context(s) as needed.
PR Checklist
Please check if your PR fulfills the following requirements:
Related Docs PR now required (if applicable)
Related Docs PR:
If n/a for Docs PR, state why it is not applicable:
What is the current behavior?
Issue Number:
#940
What is the new behavior?
Custom triggers will be able to use the default topic -> pipeline(s) matching logic.
Does this PR introduce a breaking change?
Only affects custom triggers, the message processor function no longer takes the app context as a parameter. The trigger will no longer be responsible for establishing context just preparing the message envelope.
Are there any new imports or modules? If so, what are they used for and why?
go-multierror from hashicorp is used to group pipeline errors for return to the trigger.
Are there any specific instructions or things that should be known prior to reviewing?
Other information