Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Pipeline per Topic capability #938

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Aug 24, 2021

Dependent on App SDK PR: #938

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Related Docs PR now required (if applicable)

Related Docs PR: edgexfoundry/edgex-docs#551

What is the current behavior?

Only a single functions pipeline can be created

Issue Number: #575 & #713

What is the new behavior?

Multiple functions pipeline can now created.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

  • Yes
  • No

Are there any specific instructions or things that should be known prior to reviewing?

Other information

closes #575 & #713

Signed-off-by: Leonard Goodell <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 74.93404% with 95 lines in your changes missing coverage. Please review.

Project coverage is 66.16%. Comparing base (4d69672) to head (052ea3b).
Report is 447 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/service.go 76.92% 14 Missing and 4 partials ⚠️
internal/runtime/storeforward.go 70.58% 14 Missing and 1 partial ⚠️
internal/runtime/runtime.go 87.23% 8 Missing and 4 partials ⚠️
internal/trigger/messagebus/messaging.go 65.51% 10 Missing ⚠️
pkg/transforms/encryption.go 43.75% 9 Missing ⚠️
pkg/transforms/mqttsecret.go 11.11% 8 Missing ⚠️
pkg/transforms/compression.go 53.84% 6 Missing ⚠️
pkg/transforms/coredata.go 50.00% 4 Missing ⚠️
internal/appfunction/context.go 70.00% 3 Missing ⚠️
internal/app/triggerfactory.go 0.00% 2 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   65.34%   66.16%   +0.81%     
==========================================
  Files          33       33              
  Lines        2346     2503     +157     
==========================================
+ Hits         1533     1656     +123     
- Misses        722      748      +26     
- Partials       91       99       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FelixTing
Copy link
Member

In my experience using multiple pipelines, an MQTT client with a specific client ID should be reusable.
Otherwise, MQTT clients with the same ID will be forced to constantly reconnect when publishing messages.

internal/common/config.go Show resolved Hide resolved
internal/runtime/runtime.go Show resolved Hide resolved
internal/runtime/storeforward.go Show resolved Hide resolved
pkg/interfaces/service.go Show resolved Hide resolved
@lenny-goodell lenny-goodell requested a review from AlexCuse August 26, 2021 18:07
@lenny-goodell
Copy link
Member Author

@AlexCuse , I added SetDefaultFunctionsPipeline and deprecated SetFunctionsPipeline

@AlexCuse
Copy link
Contributor

This should make it clearer I think @lenny-intel - would give a chance to get any feedback before 3 too.

AlexCuse
AlexCuse previously approved these changes Aug 26, 2021
Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell merged commit 262cc6a into edgexfoundry:main Aug 26, 2021
@lenny-goodell lenny-goodell deleted the pipeline-per-topic branch August 26, 2021 21:45
@lenny-goodell lenny-goodell linked an issue Aug 26, 2021 that may be closed by this pull request
FelixTing pushed a commit to FelixTing/app-functions-sdk-go that referenced this pull request Mar 3, 2022
* feat: Add Pipeline per Topic capability

closes edgexfoundry#575 & edgexfoundry#713

Signed-off-by: Leonard Goodell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Allow for multiple pipleines to be handled by one service
4 participants