Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create Event copy with all required fields #925

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

FilterByResource creates copy of Event without all required fields
Unit tests doesn't validate Event is valid after filtering.

Issue Number: #922

What is the new behavior?

FilterByResource now creates copy of Event with all required fields
Unit tests now validates Event is valid after filtering.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@codecov-commenter
Copy link

Codecov Report

Merging #925 (5f922c3) into main (83c633e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   65.33%   65.33%           
=======================================
  Files          33       33           
  Lines        2345     2345           
=======================================
  Hits         1532     1532           
  Misses        722      722           
  Partials       91       91           
Impacted Files Coverage Δ
pkg/transforms/filter.go 97.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c633e...5f922c3. Read the comment docs.

@lenny-goodell lenny-goodell merged commit e52849b into edgexfoundry:main Jul 15, 2021
@lenny-goodell lenny-goodell deleted the filter-by-resource-fix branch July 15, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants