refactor: Use Core Metadata Version API for version check #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
changed the title
lenny-goodell
force-pushed
the
version-check
branch
from
3575e6a to
cfbbe78
Compare
AlexCuse
previously approved these changes
Jun 17, 2021
lenny-goodell
force-pushed
the
version-check
branch
from
cfbbe78 to
6db0dfc
Compare
AlexCuse
previously approved these changes
Jun 17, 2021
lenny-goodell
changed the title
Core Data is now optional, so need to use service (Core Metadata) that will always be present. close edgexfoundry#902 Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
version-check
branch
from
6db0dfc to
7d6ed2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
==========================================
- Coverage 63.81% 63.64% -0.18%
==========================================
Files 33 33
Lines 2117 2107 -10
==========================================
- Hits 1351 1341 -10
Misses 675 675
Partials 91 91
Continue to review full report at Codecov.
|
AlexCuse
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Core Data is now optional, so need to use service that will always be present.
Issue Number: #902
What is the new behavior?
Core Data is used for version check, but is now optional service is device services are using MessageBus and no persistence is needed/enabled.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information