-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add json array check when determining CBOR of JSON encoding #896
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 63.61% 63.61%
=======================================
Files 32 32
Lines 2097 2097
=======================================
Hits 1334 1334
Misses 673 673
Partials 90 90 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@phanvanhai , a couple PR process issues to resolve:
You can use |
Signed-off-by: phanvanhai <[email protected]>
Signed-off-by: phanvanhai <[email protected]>
Signed-off-by: phanvanhai <[email protected]>
Sorry I'm not fluent in git yet. If the problem is still there, please suggest me to fix it. |
@phanvanhai , it is still failing since original commit is still there (i.e. commits not squashed) , but I can fix that when I merge the PR. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Only check for JSON format starting with
{
Issue Number: #894
What is the new behavior?
Add a check for JSON format starting with
[
for arrays.Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information