Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update to use new Port assignments #850

Merged
merged 2 commits into from
May 20, 2021

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 19, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What is the current behavior?

Ports assigned core Core/Supporting services are 408xx range
App services never had a ranged assigned

Issue Number: #847

What is the new behavior?

Ports assigned for Core/Supporting services are 588xx range
App services now assigned the 597xx range

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

jim-wang-intel
jim-wang-intel previously approved these changes May 19, 2021
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #850 (5289a50) into master (1540700) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files          31       31           
  Lines        1980     1980           
=======================================
  Hits         1243     1243           
  Misses        647      647           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1540700...5289a50. Read the comment docs.

@lenny-goodell
Copy link
Member Author

recheck

@lenny-goodell lenny-goodell marked this pull request as ready for review May 20, 2021 17:53
@lenny-goodell lenny-goodell merged commit 497a5d9 into edgexfoundry:master May 20, 2021
@lenny-goodell lenny-goodell deleted the ports branch July 7, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants